Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more rules for blocks #112

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Add more rules for blocks #112

merged 2 commits into from
Jun 27, 2022

Conversation

Morriar
Copy link
Contributor

@Morriar Morriar commented Jun 27, 2022

  • Change Layout/RedundantLineBreak config to InspectBlocks: true so this:

    sig do
  void
end

    will be corrected into this:

    sig { void }

  • Enable Style/BlockDelimiters by default so this:

    sig do void end

    will be corrected into this:

    sig { void }

@Morriar Morriar added the enhancement New feature or request label Jun 27, 2022
@Morriar Morriar requested a review from a team as a code owner June 27, 2022 17:17
@Morriar Morriar self-assigned this Jun 27, 2022
@Morriar Morriar merged commit f210297 into main Jun 27, 2022
@Morriar Morriar deleted the at-rbi-redundant-line-break branch June 27, 2022 19:36
@shopify-shipit shopify-shipit bot temporarily deployed to production June 30, 2022 15:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

@rafaelfranca rafaelfranca rafaelfranca approved these changes

Assignees

@Morriar Morriar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Morriar @rafaelfranca @vinistock